-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Go modules as /v3 #261
Conversation
If the vendor folder is omitted, on an installation step, I think, If the vendor folder is presented in the source code, you can give this guarantee. Otherwise, no. So, I suggest to keep the vendor folder in the project. |
Thank you for the feedback, although I'd disagree with this bit.
Most (larger) project I worked on have consumed the library to extend its functionality. Whereas smaller side-projects I use the CLI. Based on observation, after modules and the Go module proxy were introduced more libraries are dropping |
Good points @alxmsl. Goose is both CLI and a library, as you can build custom goos binary with Go migrations. I don't have a strong opinion on this, but I'd be OK with keeping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll remove Most, if not all, of these packages are widely used in the community and are cached by the official Go module proxy. If there is strong objection we can always bring them back via |
Just one my objection was about the case when a dependency has a minor version change with a backward incompatibility. |
This introduces Go module support for
goose
. The intention is to keep/v3
backward-compatible with the existing tagged versions:v2.x.y
and any breaking changes will roll into/v4
Up for discussion whether we want to keep the
/vendor
folder? For internal projects, I definitely still see vendor as useful, but for OSS projects we can probably remove. Thoughts?